Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-97 Refactor try/catch for window.onYouTubeIframeAPIReady.resolve on video initialization #1371

Merged
merged 1 commit into from
Sep 18, 2023
Merged

ENG-97 Refactor try/catch for window.onYouTubeIframeAPIReady.resolve on video initialization #1371

merged 1 commit into from
Sep 18, 2023

Conversation

bryanlandia
Copy link

@bryanlandia bryanlandia commented Sep 14, 2023 •
edited
Loading

Change description

Refactor try/catch for window.onYouTubeIframeAPIReady.resolve on video initialization
Rename Error instance as seems to have caused a name collision when minified

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-97

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bryanlandia
Refactor try/catch on window.onYouTubeIframeAPIReady.resolve
46a894d 
Rename Error instance as  seems to have caused a name collision when minified
@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 318
Current conflicts 318
Summary Good work! No added conflicts.

@bryanlandia bryanlandia marked this pull request as ready for review September 18, 2023 18:43
@bryanlandia
Copy link
Author

Finished testing on devstack, looks good.

@bryanlandia bryanlandia merged commit 460a6fa into main Sep 18, 2023
11 checks passed
@bryanlandia bryanlandia deleted the bugfix/ENG-97-catch-and-retry-yt-api-errs branch September 18, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirtds amirtds amirtds approved these changes

@xscrio xscrio Awaiting requested review from xscrio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanlandia @amirtds